You are hereHome / General / Side Was Down: Shame On Me

Side Was Down: Shame On Me


By Gerd Riesselmann - Posted on 15 January 2005

I messed up my page yesterday, so it just displayed an error message. Shame on me, since I didn't test a fix I applied to WordPress, thinking this fix was too trivial to do any harm. Wrong! There is no such thing as a simple fix, and everything must be testes, of course. But good to be reminded again.

What happended?

Since I switched to Gmail , I'm having troubles with mails sended by WordPress. Gmail moves them all right into the spam fodler, for they don't provide a sender's address. It turned out I'm suffering from WordPress bug number 263: Additional line breaks added in the email's header.

Well, there is no workaround yet, so I decided to move the "from" section to the top of the header, so Gmail at least will recognize the sender. That's why I changed

$message_headers = "MIME-Version: 1.0\r\n"
. "$from\r\n"
. "Content-Type: text/plain; charset="" . get_settings('blog_charset') . ""\r\n";

to

$message_headers = "$from\r\n"
. "Content-Type: text/plain; charset="" . get_settings('blog_charset') . ""\r\n";
. "MIME-Version: 1.0\r\n"

See the mistake? I forgot to move the semicolon from line 2 to line 3. Stupid, stupid me.

Tags